dongxiaoman commented on code in PR #9391:
URL: https://github.com/apache/pinot/pull/9391#discussion_r972169945
##########
pinot-broker/src/main/java/org/apache/pinot/broker/api/AccessControl.java:
##########
@@ -47,4 +47,13 @@ default boolean hasAccess(RequesterIdentity
requesterIdentity) {
* @return {@code true} if authorized, {@code false} otherwise
*/
boolean hasAccess(RequesterIdentity requesterIdentity, BrokerRequest
brokerRequest);
+
+ /**
+ * Determine whether authentication is required for annotated (controller)
endpoints only
+ *
+ * @return {@code true} if annotated methods are protected only, {@code
false} otherwise
+ */
+ default boolean protectAnnotatedOnly() {
+ return true;
+ }
Review Comment:
I thought we can avoid calling Auth endpoints twice. `AuthenticationFilter`
verifies once, the `client/sql` endpoints have its own AccessControl that calls
again.
Can we confirm that it is fine to just authenticate everything?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
