navina commented on code in PR #9424:
URL: https://github.com/apache/pinot/pull/9424#discussion_r973934984
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/realtime/converter/ColumnDescriptionsContainer.java:
##########
@@ -0,0 +1,48 @@
+package org.apache.pinot.segment.local.realtime.converter;
+
+import java.util.List;
+
+
+public class ColumnDescriptionsContainer {
+ private final String _sortedColumn;
+ private final List<String> _invertedIndexColumns;
+ private final List<String> _textIndexColumns;
+ private final List<String> _fstIndexColumns;
+ private final List<String> _noDictionaryColumns;
+ private final List<String> _varLengthDictionaryColumns;
+
+ public ColumnDescriptionsContainer(String sortedColumn, List<String>
invertedIndexColumns,
+ List<String> textIndexColumns, List<String> fstIndexColumns,
List<String> noDictionaryColumns,
+ List<String> varLengthDictionaryColumns) {
+ _sortedColumn = sortedColumn;
+ _invertedIndexColumns = invertedIndexColumns;
+ _textIndexColumns = textIndexColumns;
+ _fstIndexColumns = fstIndexColumns;
+ _noDictionaryColumns = noDictionaryColumns;
+ _varLengthDictionaryColumns = varLengthDictionaryColumns;
+ }
+
+ public String getSortedColumn() {
+ return _sortedColumn;
+ }
+
+ public List<String> getInvertedIndexColumns() {
+ return _invertedIndexColumns;
+ }
+
+ public List<String> getTextIndexColumns() {
+ return _textIndexColumns;
+ }
+
+ public List<String> getFstIndexColumns() {
+ return _fstIndexColumns;
+ }
+
+ public List<String> getNoDictionaryColumns() {
Review Comment:
Yeah. I wasn't sure why that is the case. It is being passed into
`RealtimeSegmentConverter`. But even there, the member variable
`_noDictionaryColumns` was unused. So, not sure why this exists. I didn't want
to change any functionality in a refactoring PR. So, left it as is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
