siddharthteotia commented on code in PR #9454:
URL: https://github.com/apache/pinot/pull/9454#discussion_r981988856
##########
pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/creator/IndexCreationContext.java:
##########
@@ -102,7 +102,8 @@ public Builder withColumnMetadata(ColumnMetadata
columnMetadata) {
.withTotalDocs(columnMetadata.getTotalDocs())
.withDictionary(columnMetadata.hasDictionary())
.withMinValue(columnMetadata.getMinValue())
- .withMaxValue(columnMetadata.getMaxValue());
+ .withMaxValue(columnMetadata.getMaxValue())
+
.withMaxNumberOfMultiValueElements(columnMetadata.getMaxNumberOfMultiValues());
Review Comment:
Since this PR is adding support for SV, can we avoid this change ? No harm
but would prefer to keep all changes for SV and MV to be localized in their own
separate PRs if possible for easy review / tracking etc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
