siddharthteotia commented on code in PR #9496:
URL: https://github.com/apache/pinot/pull/9496#discussion_r984154010
##########
pinot-query-runtime/src/test/java/org/apache/pinot/query/runtime/QueryRunnerTest.java:
##########
@@ -151,6 +151,8 @@ private Object[][] provideTestSql() {
new Object[]{"SELECT * FROM b ORDER BY col1, col2 DESC LIMIT 3"},
new Object[]{"SELECT * FROM a ORDER BY col1, ts LIMIT 10"},
new Object[]{"SELECT * FROM a ORDER BY col1 LIMIT 20"},
+ new Object[]{"SELECT * FROM a ORDER BY col1, ts LIMIT 1, 2"},
+ new Object[]{"SELECT * FROM a ORDER BY col1, ts LIMIT 2 OFFSET 1"},
Review Comment:
FWIW - We don't support pagination (OFFSET / FETCH based syntax) even in the
existing engine. Many times, pinot users have thought we support pagination
(because syntax is supported) and the solution brute force for selection
queries and does not work for other queries. So, probably we should not worry
about adding this test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
