saurabhd336 commented on code in PR #9356:
URL: https://github.com/apache/pinot/pull/9356#discussion_r984236830
##########
pinot-broker/src/main/java/org/apache/pinot/broker/routing/timeboundary/TimeBoundaryManager.java:
##########
@@ -105,6 +106,14 @@ public TimeBoundaryManager(TableConfig tableConfig,
ZkHelixPropertyStore<ZNRecor
@SuppressWarnings("unused")
public void init(IdealState idealState, ExternalView externalView,
Set<String> onlineSegments) {
// Bulk load time info for all online segments
+ String enforcedTimeBoundary =
idealState.getRecord().getSimpleField(CommonConstants.IdealState.QUERY_TIME_BOUNDARY);
Review Comment:
It is needed to correctly update the metric shows the difference b/w current
time boundary and max(end time across all segments)
##########
pinot-broker/src/main/java/org/apache/pinot/broker/routing/timeboundary/TimeBoundaryManager.java:
##########
@@ -167,6 +181,14 @@ private void updateTimeBoundaryInfo(long maxEndTimeMs) {
@SuppressWarnings("unused")
public synchronized void onAssignmentChange(IdealState idealState,
ExternalView externalView,
Set<String> onlineSegments) {
+ String enforcedTimeBoundary =
idealState.getRecord().getSimpleField(CommonConstants.IdealState.QUERY_TIME_BOUNDARY);
Review Comment:
It is needed to correctly update the metric shows the difference b/w current
time boundary and max(end time across all segments)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
