walterddr commented on code in PR #9583:
URL: https://github.com/apache/pinot/pull/9583#discussion_r993988279
##########
pinot-integration-test-base/src/test/java/org/apache/pinot/integration/tests/BaseClusterIntegrationTest.java:
##########
@@ -586,11 +586,13 @@ protected void stopKafka() {
* Get current result for "SELECT COUNT(*)".
*
* @return Current count start result
- * @throws Exception
*/
- protected long getCurrentCountStarResult()
- throws Exception {
- return getPinotConnection().execute("SELECT COUNT(*) FROM " +
getTableName()).getResultSet(0).getLong(0);
+ protected long getCurrentCountStarResult() {
+ return getCountStarResult(getTableName());
+ }
+
+ protected long getCountStarResult(String tableName) {
+ return getPinotConnection().execute("SELECT COUNT(*) FROM " +
tableName).getResultSet(0).getLong(0);
Review Comment:
why this change? this is only needed in that test right? wonder if we need
another method on base
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
