klsince commented on code in PR #9306:
URL: https://github.com/apache/pinot/pull/9306#discussion_r995148514
##########
pinot-core/src/main/java/org/apache/pinot/core/data/manager/InstanceDataManager.java:
##########
@@ -86,11 +86,17 @@ void addRealtimeSegment(String realtimeTableName, String
segmentName)
throws Exception;
/**
- * Removes a segment from a table.
+ * Removes a segment from a table but not dropping its data from server.
*/
void removeSegment(String tableNameWithType, String segmentName)
throws Exception;
+ /**
+ * Delete segment data from the server.
+ */
+ void dropSegment(String tableNameWithType, String segmentName)
Review Comment:
will rename removeSegment to offloadSegment() and call this one
deleteSegment()
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
