jameskelleher commented on code in PR #9494:
URL: https://github.com/apache/pinot/pull/9494#discussion_r995572406
##########
kubernetes/helm/pinot/templates/broker/service-external.yaml:
##########
@@ -34,4 +34,6 @@ spec:
port: {{ .Values.broker.external.port }}
selector:
{{- include "pinot.brokerMatchLabels" . | nindent 4 }}
+ loadBalancerSourceRanges:
+{{ toYaml .Values.broker.service.loadBalancerSourceRanges | indent 4 }}
Review Comment:
@walterddr good catch, the dry run failed. I made an update that maintains
the same behavior for the previous two tests, as well as handles the case you
provided (`loadBalancerSourceRanges` will not be in the result template if not
provided as a value)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
