siddharthteotia commented on code in PR #9610:
URL: https://github.com/apache/pinot/pull/9610#discussion_r997595595
##########
pinot-query-runtime/src/test/java/org/apache/pinot/query/QueryTestSet.java:
##########
@@ -95,6 +95,10 @@ public Object[][] provideTestSql() {
+ " WHERE a.col1 IN ('foo') AND b.col2 NOT IN ('')"},
// Range conditions with continuous and non-continuous range.
+ new Object[]{"SELECT a.col1, SUM(CASE WHEN a.col2 = 'foo' OR a.col2 =
'alice' THEN 1 ELSE 0 END) AS match_sum, "
Review Comment:
Might want to add an explicit test in addition to the ones above (that test
the functionality provided calcite rewrites) just to ensure this always works
even if Calcite ever changes it's mind
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
