jadami10 opened a new pull request, #9766: URL: https://github.com/apache/pinot/pull/9766
I'm hoping someone that understands this code path well can review. But this marks the `spark_launcher` jar to be provided. We ran into this in a really weird case: - we are in the midst of a spark2 -> spark3 migration - we fork spark, and we reverted a change to the launcher on our spark fork to work with the old launcher sh files - we build pinot with shaded jars, i believe to pull in a correct, later hadoop dependency Because this jar gets shaded, we were using the later code that didn't work with our launcher shell script. Spark core is already scoped as [provided](https://github.com/apache/pinot/blob/master/pinot-plugins/pinot-batch-ingestion/pinot-batch-ingestion-spark-3.2/pom.xml#L55), so this seems like the desired behavior here, too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
