61yao commented on code in PR #9760:
URL: https://github.com/apache/pinot/pull/9760#discussion_r1019960002
##########
pinot-query-runtime/src/test/java/org/apache/pinot/query/runtime/QueryRunnerExceptionTest.java:
##########
@@ -71,11 +71,11 @@ private Object[][] provideTestSqlWithExecutionException() {
// Function with incorrect argument signature should throw runtime
exception
new Object[]{"SELECT least(a.col2, b.col3) FROM a JOIN b ON a.col1 =
b.col1",
"ArithmeticFunctions.least(double,double) with arguments"},
- // Function that tries to cast String to Number should throw runtime
exception
- new Object[]{"SELECT a.col2, b.col1 FROM a JOIN b ON a.col1 = b.col3",
"transform function: cast"},
+ // TODO: this error is thrown but not returned through mailbox. need
another test for asserting failure
Review Comment:
Sorry, just saw this. Can you explain more on why it doesn't need to be
async?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
