klsince commented on PR #9772: URL: https://github.com/apache/pinot/pull/9772#issuecomment-1312370135
As tested, crc check didn't affect loading immutable segments for RT table. And when pushing immutable segments to RT table, it's `addOrReplaceSegment()` that gets called to handle the helix custom SegmentRefreshMessage, the same method used for OFFLINE table, so crc check happens for immutable segments in RT table already. This PR makes segment loading logic more consistent. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
