walterddr commented on code in PR #9792:
URL: https://github.com/apache/pinot/pull/9792#discussion_r1022138853
##########
pinot-query-planner/src/main/java/org/apache/pinot/query/planner/logical/RexExpression.java:
##########
@@ -204,6 +204,7 @@ public FieldSpec.DataType getDataType() {
class FunctionCall implements RexExpression {
@ProtoProperties
private SqlKind _sqlKind;
+ // TODO: Make sure _sqlKind matches _functionName.
Review Comment:
this is not necessarily needed. otherwise we won't need both in the
RexExpression
##########
pinot-query-planner/src/main/java/org/apache/pinot/query/planner/logical/StagePlanner.java:
##########
@@ -41,12 +41,10 @@
* This class is non-threadsafe. Do not reuse the stage planner for multiple
query plans.
*/
public class StagePlanner {
- private final PlannerContext _plannerContext;
private final WorkerManager _workerManager;
private int _stageIdCounter;
public StagePlanner(PlannerContext plannerContext, WorkerManager
workerManager) {
- _plannerContext = plannerContext;
Review Comment:
yes please don't remove planner context. it would be used for many other
heuristics going forward even though it is not being used for now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
