mcvsubbu commented on code in PR #9816:
URL: https://github.com/apache/pinot/pull/9816#discussion_r1024527281
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/assignment/segment/strategy/BalancedNumSegmentAssignmentStrategy.java:
##########
@@ -51,6 +51,10 @@ public void init(HelixManager helixManager, TableConfig
tableConfig) {
SegmentsValidationAndRetentionConfig validationAndRetentionConfig =
tableConfig.getValidationConfig();
Preconditions.checkState(validationAndRetentionConfig != null, "Validation
Config is null");
_replication = validationAndRetentionConfig.getReplicationNumber();
+ // Number of replicas per partition of low-level consumers check is for
the real time tables only
+ if (validationAndRetentionConfig.getReplicasPerPartition() != null) {
Review Comment:
Please tag this PR with the (open) issue
https://github.com/apache/pinot/issues/8804.
Since we have a problem in production, we should fix in some way (add TODOs
as needed), but fix the overall replication/replicasPerPartition as a part of
that issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
