snleee commented on code in PR #9815:
URL: https://github.com/apache/pinot/pull/9815#discussion_r1024823997
##########
pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/main/java/org/apache/pinot/plugin/minion/tasks/mergerollup/MergeRollupTaskGenerator.java:
##########
@@ -383,16 +385,18 @@ public List<PinotTaskConfig>
generateTasks(List<TableConfig> tableConfigs) {
}
}
+ int partitionSeq = 0;
Review Comment:
Actually, there's a bit better approach :)
1. Check the `partitionToSegments.keys() - List<List<Integer>>` and validate
if the length of the value list is all 1 (this means that the data is correctly
partitioned).
2. If so, we can directly use the partition value. If not, we can fall back
to the partitionSeq to avoid too long naming.
This approach will try to put the correct information at the best effort.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
