agavra commented on code in PR #9933:
URL: https://github.com/apache/pinot/pull/9933#discussion_r1042784535
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/executor/RoundRobinScheduler.java:
##########
@@ -95,7 +97,14 @@ public boolean hasNext() {
@Override
public OpChain next() {
- return _ready.poll();
+ OpChain op = _ready.poll();
+ trace("Polled " + op);
+ return op;
+ }
+
+ @Override
+ public int size() {
+ return _ready.size() + _available.size();
Review Comment:
it also can't be part of the interface because it's implementation specific
😢
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/executor/RoundRobinScheduler.java:
##########
@@ -64,6 +64,7 @@ public void register(OpChain operatorChain, boolean isNew) {
// immediately be considered ready in case it does not need
// read from any mailbox (e.g. with a LiteralValueOperator)
(isNew ? _ready : _available).add(operatorChain);
+ trace("registered " + operatorChain);
Review Comment:
yup
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
