snleee commented on code in PR #9954:
URL: https://github.com/apache/pinot/pull/9954#discussion_r1044638238
##########
pinot-common/src/main/java/org/apache/pinot/common/metrics/ControllerGauge.java:
##########
@@ -52,6 +52,7 @@ public enum ControllerGauge implements AbstractMetrics.Gauge {
OFFLINE_TABLE_COUNT("TableCount", true),
DISABLED_TABLE_COUNT("TableCount", true),
PERIODIC_TASK_NUM_TABLES_PROCESSED("PeriodicTaskNumTablesProcessed", true),
+
MINION_TASK_METADATA_LAST_UPDATE_TIME_MS("MinionTaskMetadataLastUpdateTimeMs",
true),
Review Comment:
Can we think of normalizing the metrics? Reporting the raw timestamp value
will require ppl to re-interpret that to the human readable format so it's
going to be a bit hard to use.
For example, the same information can be defined as `time since last update
in hours (or days)`. This will show as low number in regular cases and it will
increase if there's no update for a long time. Once we make some progress
again, it will go down to 0 again.
For data purge or merge/rollup metrics, we used the similar normalized
metrics because it's much easier to understand and also easier to set the
alerts if we want to.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
