agavra opened a new issue, #10004:
URL: https://github.com/apache/pinot/issues/10004

   There are two ways of calling performing timestamp addition in pinot:
   1. `TIMESTAMPADD`
   2. `DATEADD`
   
   The former is parsed directly by Calcite while the latter is passed into the 
Pinot engine. This leads to a few issues:
   1. `TIMESTAMPADD` expects a time interval literal while `DATEADD` expects a 
string as the first argument. This means that `TIMESTAMPADD('DAY', ...)` is 
invalid and should be `TIMESTAMPADD(DAY, ...` while `DATEADD(DAY, ...)` is 
invalid and should be `DATEADD('DAY', ...`
   2. Calcite parses the first argument as a `TimestampInterval()`, which does 
not include some units that are supported in `DATEADD` (such as, notably, 
`MILLISECOND`) which means that `TIMESTAMPADD(MILLISECOND` fails to parse while 
`DATEADD('MILLISECOND'` succeeds


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to