walterddr commented on code in PR #10045:
URL: https://github.com/apache/pinot/pull/10045#discussion_r1062702053
##########
pinot-connectors/pinot-flink-connector/src/main/java/org/apache/pinot/connector/flink/sink/PinotSinkFunction.java:
##########
@@ -151,4 +148,18 @@ private void flush()
LOG.info("Pinot segment uploaded to {}", segmentURI);
});
}
+
+ @Override
+ public List<GenericRow> snapshotState(long checkpointId, long timestamp) {
+ return _pendingRows;
+ }
+
+ @Override
+ public void restoreState(List<GenericRow> pendingRows)
+ throws Exception {
+ for (GenericRow row: pendingRows) {
+ _segmentWriter.collect(row);
+ _segmentNumRecord++;
+ }
+ }
Review Comment:
need to put pendingRows back into _pendingRows. otherwise in the case of
immediate failure after restore, and a snapshot is triggered before the flush
is successful, these restored data are lost.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
