jugomezv commented on code in PR #9994:
URL: https://github.com/apache/pinot/pull/9994#discussion_r1062844784
##########
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeSegmentDataManager.java:
##########
@@ -69,4 +69,13 @@ protected static PinotDataBufferMemoryManager
getMemoryManager(String consumerDi
public abstract Map<String, PartitionLagState> getPartitionToLagState(
Map<String, ConsumerPartitionState> consumerPartitionStateMap);
+
+ /**
+ * The RT segment data manager can handle status change from external
components like the ConsumptionStatusChecker
+ * etc. Currently, it acts as a way to signal the RT Segment data manager
that the current partition has caught up.
+ *
+ * @param caughtUpWithUpstream Boolean indicating if the partition has
caught up with upstream source or not based on
+ * the strategy used in the {@literal
IngestionBasedConsumptionStatusChecker}
+ */
+ public abstract void notifyConsumptionCaughtUp(boolean caughtUpWithUpstream);
Review Comment:
Agreed--we likely can change things as you suggest above but there is some
other things Subbu brings up in some of the other comments which likely makes
it useful for us to have a different approach for muting the metrics in this
period, let's discuss in zoom meeting this afternoon.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
