siddharthteotia commented on code in PR #10054:
URL: https://github.com/apache/pinot/pull/10054#discussion_r1066335355
##########
pinot-core/src/test/java/org/apache/pinot/queries/InterSegmentAggregationSingleValueQueriesTest.java:
##########
@@ -255,7 +255,7 @@ public void testDistinctCount() {
public void testDistinctCountHLL() {
String query = "SELECT DISTINCTCOUNTHLL(column1) AS v1,
DISTINCTCOUNTHLL(column3) AS v2 FROM testTable";
- // Without filter, query should be answered by
DictionaryBasedAggregationOperator (numEntriesScannedPostFilter = 0)
+ // Without filter, query should be answered by
NonScanBasedAggregationOperator (numEntriesScannedPostFilter = 0)
Review Comment:
(nit) you might want to clarify that this is the case with dictionary based
column
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
