vvivekiyer commented on code in PR #10093:
URL: https://github.com/apache/pinot/pull/10093#discussion_r1066362108
##########
pinot-segment-local/src/test/java/org/apache/pinot/segment/local/segment/index/loader/ForwardIndexHandlerTest.java:
##########
@@ -1374,7 +1373,7 @@ public void testDisableForwardIndexForSingleRawColumn()
// This value is based on the rows in createTestData().
dictionaryElementSize = 7;
} else if (dataType == FieldSpec.DataType.BIG_DECIMAL) {
- dictionaryElementSize = 11;
+ dictionaryElementSize = 4;
Review Comment:
The existing code uses a random BASE_BIG_DECIMAL. Depending on the random
value used in BASE_BIG_DECIMAL, the `dictionaryElementSize` varies.
In the `validateMetadata()` function, we check if the dictionaryElementSize
remains the same
`assertEquals(columnMetadata.getColumnMaxLength(), dictionaryElementSize,
column);`
This was causing the flakiness. Now we make it deterministic by not using
BASE_BIG_DECIMAL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
