zhtaoxiang commented on code in PR #10104:
URL: https://github.com/apache/pinot/pull/10104#discussion_r1067604827
##########
pinot-common/src/main/java/org/apache/pinot/common/metrics/AbstractMetrics.java:
##########
@@ -707,15 +708,16 @@ public void removeTableGauge(final String tableName,
final G gauge) {
/**
+ * @deprecated please use removeTableGauge(final String tableName, final
String key, final G gauge) instead
+ *
* Removes a table gauge given the table name and the gauge.
* The add/remove is expected to work correctly in case of being invoked
across multiple threads.
* @param tableName table name
+ * @param partitionId The partition id
* @param gauge the gauge to be removed
*/
public void removePartitionGauge(final String tableName, final int
partitionId, final G gauge) {
Review Comment:
@navina that's a great question!
Personally, I feel that even with this method, we cannot 100% ensure that
partition level metric names have a unified pattern (because users may abuse
`setValueOfTableGauge(final String tableName, final G gauge, final long value)`
to emit partition level metrics).
At the same time, I agree with you, @mcvsubbu and @jugomezv that it's highly
possible that people choose to use this method if we have it.
So let's keep it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
