Jackie-Jiang commented on code in PR #10092:
URL: https://github.com/apache/pinot/pull/10092#discussion_r1068747750
##########
pinot-core/src/main/java/org/apache/pinot/core/plan/GroupByPlanNode.java:
##########
@@ -59,6 +59,7 @@ public Operator<GroupByResultsBlock> run() {
assert _queryContext.getGroupByExpressions() != null;
if (_queryContext.hasFilteredAggregations()) {
+ assert _queryContext.getFilteredAggregationFunctions() != null;
Review Comment:
We cannot annotate it as `Nonnull` because it is `Nonnull` only for
aggregation queries. Basically `_queryContext.getAggregationFunctions()` and
`_queryContext.getFilteredAggregationFunctions()` will both be `null` or
`non-null`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
