agavra commented on code in PR #10120:
URL: https://github.com/apache/pinot/pull/10120#discussion_r1072423883
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/LeafStageTransferableBlockOperator.java:
##########
@@ -283,7 +283,11 @@ private static Object[] canonicalizeRow(Object[] row,
DataSchema dataSchema) {
for (int colId = 0; colId < row.length; colId++) {
Object value = row[colId];
if (value != null) {
- resultRow[colId] = dataSchema.getColumnDataType(colId).convert(value);
+ if (dataSchema.getColumnDataType(colId) ==
DataSchema.ColumnDataType.OBJECT) {
+ resultRow[colId] = value;
+ } else {
+ resultRow[colId] =
dataSchema.getColumnDataType(colId).convert(value);
+ }
Review Comment:
good catch, this was from a previous iteration of the PR that was leftover
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]