snleee commented on code in PR #10132:
URL: https://github.com/apache/pinot/pull/10132#discussion_r1073132781
##########
pinot-minion/src/main/java/org/apache/pinot/minion/api/resources/PinotTaskProgressResource.java:
##########
@@ -84,4 +86,34 @@ public String getSubtaskProgress(
.build());
}
}
+
+ @GET
+ @Path("/tasks/subtask/state/{subTaskState}/progress")
+ @Produces(MediaType.APPLICATION_JSON)
+ @ApiOperation("Get finer grained task progress tracked in memory for
subtasks with the given state")
+ @ApiResponses(value = {
+ @ApiResponse(code = 200, message = "Success"), @ApiResponse(code = 500,
message = "Internal server error")
+ })
+ public String getSubtaskWithGivenStateProgress(
Review Comment:
I think that we can merge this function with `/tasks/subtask/progress`? The
controller side can provide the different filter parameters. As long as the
existing API correctly provides the filter, we can keep the backward
compatibility of the existing API.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
