zhtaoxiang commented on code in PR #10132:
URL: https://github.com/apache/pinot/pull/10132#discussion_r1073187321
##########
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotTaskRestletResource.java:
##########
@@ -419,7 +423,7 @@ public Map<String, PinotTaskConfig> getSubtaskConfigs(
@GET
@Path("/tasks/subtask/{taskName}/progress")
@Produces(MediaType.APPLICATION_JSON)
- @ApiOperation("Get progress of specified sub tasks for the given task
tracked by worker in memory")
+ @ApiOperation("Get progress of specified sub tasks for the given task
tracked by minion worker in memory")
Review Comment:
Thanks for the suggestions!
This should also works. However, it may not be ideal because
1. If we only return the task names and corresponding subtasks from
`/tasks/subtask/state/{subTaskState}/progress`,
(1) Task names and corresponding subtasks may not provide enough debugging
information. It's highly possible that users still need to invoke
`/tasks/subtask/{taskName}/progress` to get more progress information back.
(2) The response size will be smaller, but Pinot needs to perform (almost)
the same computation. The computation itself is not simplified.
(3) While smaller response will help with data transfer, but I don't see a
case that we will invoke this API frequently, so response size may not be a
concern.
Even if we want to reduce response size, I feel we can add a separate API to
achieve the goal if it's needed
2. Since task names and corresponding subtasks from
`/tasks/subtask/state/{subTaskState}/progress` may not belong to the same task,
users need to make multiple calls to `/tasks/subtask/{taskName}/progress` in
order to get process information, which may make operations complex.
Any ideas?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
