ankitsultana commented on code in PR #10148:
URL: https://github.com/apache/pinot/pull/10148#discussion_r1081312765
##########
pinot-query-planner/src/main/java/org/apache/pinot/query/type/TypeFactory.java:
##########
@@ -54,23 +54,23 @@ public RelDataType createRelDataTypeFromSchema(Schema
schema) {
private RelDataType toRelDataType(FieldSpec fieldSpec) {
switch (fieldSpec.getDataType()) {
case INT:
- return createSqlType(SqlTypeName.INTEGER);
+ return createTypeWithNullability(createSqlType(SqlTypeName.INTEGER),
true);
Review Comment:
Can you check this patch with the COLOCATED_JOIN quickstart and this query?
I saw a broadcast distributed stage created for some reason. Also the
projection wasn't pushed down to the userAttributes side.
```
SELECT
COUNT(*)
FROM
userAttributes_OFFLINE
WHERE
userUUID NOT IN (
SELECT userUUID FROM userGroups_OFFLINE WHERE groupUUID = 'group-2'
)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
