saurabhd336 commented on code in PR #10089:
URL: https://github.com/apache/pinot/pull/10089#discussion_r1081688733
##########
pinot-core/src/test/java/org/apache/pinot/core/data/manager/BaseTableDataManagerTest.java:
##########
@@ -191,7 +191,6 @@ public void testReloadSegmentUseLocalCopy()
fail();
} catch (Exception e) {
// As expected, segment reloading fails due to missing the local segment
dir.
- assertTrue(e.getMessage().contains("does not exist or is not a
directory"));
Review Comment:
Still fails with an exception (If it didn't, test would fail (see
https://github.com/apache/pinot/pull/10089/files#diff-2ca49ed375e7b21a34397df398e1586e8ee64283461abe4a9a2cae17097fbab9R191))
Just not the one with the message `does not exist or is not a directory`...
##########
pinot-core/src/test/java/org/apache/pinot/core/data/manager/BaseTableDataManagerTest.java:
##########
@@ -191,7 +191,6 @@ public void testReloadSegmentUseLocalCopy()
fail();
} catch (Exception e) {
// As expected, segment reloading fails due to missing the local segment
dir.
- assertTrue(e.getMessage().contains("does not exist or is not a
directory"));
Review Comment:
Same for next one
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
