navina commented on code in PR #10136:
URL: https://github.com/apache/pinot/pull/10136#discussion_r1081975469
##########
pinot-spi/src/main/java/org/apache/pinot/spi/config/table/SegmentsValidationAndRetentionConfig.java:
##########
@@ -49,9 +49,13 @@ public class SegmentsValidationAndRetentionConfig extends
BaseJsonConfig {
// For more usage of this field, please refer to this design doc:
https://tinyurl.com/f63ru4sb
private String _peerSegmentDownloadScheme;
+ // Indicates if the segment should be uploaded to the deep store's file
system or to the controller during the
+ // segment commit protocol. By default, segment is uploaded to the
controller during commit.
+ // If this flag is set to true, the segment is uploaded to deep store.
+ private boolean _uploadToFileSystem = false;
Review Comment:
> For clarity, also suggest renaming to _serverUploadToDeepStore because we
want to emphasize that we want the server to do the upload
This makes sense.
> this flag belongs to the stream ingestion config, suggest moving it to
StreamIngestionConfig
yeah. I also agree it fits better in stream ingestion config. Should peer
segment download scheme remain in `SegmentsValidationAndRetentionConfig` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
