walterddr commented on code in PR #10151:
URL: https://github.com/apache/pinot/pull/10151#discussion_r1081975613
##########
pinot-segment-local/src/test/java/org/apache/pinot/segment/local/segment/index/readerwriter/ValueReaderComparisonTest.java:
##########
@@ -156,22 +156,27 @@ void testSuperiorPrefixes(ValueReader reader, int
numBytesPerValue, String... st
void testConsistent(ValueReader reader, int numBytesPerValue, int
numValuesToCompare) {
for (int i = 0; i < numValuesToCompare; i++) {
byte[] bytes = new
byte[ThreadLocalRandom.current().nextInt(numBytesPerValue * 2)];
- assertConsistentUtf8Comparison(reader, i, numBytesPerValue, new
String(bytes, StandardCharsets.UTF_8));
- for (int j = 0; j < 128; j++) {
+
+ for (int j = 1; j < 128; j++) {
Review Comment:
e.g. all zero fill data are not considered to be valid?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
