agavra commented on code in PR #10157:
URL: https://github.com/apache/pinot/pull/10157#discussion_r1083045733
##########
pinot-query-planner/src/main/java/org/apache/pinot/query/routing/ServerAddress.java:
##########
@@ -26,10 +26,16 @@ public class ServerAddress {
Review Comment:
`ServerAddress` is just hostname:port:partition (or whatever I rename it to)
`VirtualServer` is essentially a `ServerAddress` + `ServerInstance`, which
has a lot more information than just the hostname/port/partition. I didn't
model it like that because the information in `ServerAddress` would be
redundant. I couldn't just use `VirtualServer` throughout the code base because
there are some places where we don't have all the information we need to build
an instance of `ServerInstance` (and therefore `VirtualServer`)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
