Jackie-Jiang commented on code in PR #10158:
URL: https://github.com/apache/pinot/pull/10158#discussion_r1084491069
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/store/SegmentLocalFSDirectory.java:
##########
@@ -248,25 +250,26 @@ protected void load()
private synchronized void loadData()
throws IOException {
- if (_columnIndexDirectory != null) {
- return;
+ if (_columnIndexDirectory == null) {
Review Comment:
But after `writer.close()` is called, I don't think we can read the segment
anymore.
The reader/writer name can be misleading as they are not independent of the
segment directory. Unless I am missing something?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
