61yao commented on code in PR #10114:
URL: https://github.com/apache/pinot/pull/10114#discussion_r1084818698
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/service/QueryDispatcher.java:
##########
@@ -208,8 +213,8 @@ public DispatchClient(String host, int port) {
_blockingStub = PinotQueryWorkerGrpc.newBlockingStub(_managedChannel);
}
- public Worker.QueryResponse submit(Worker.QueryRequest request) {
- return _blockingStub.submit(request);
+ public Worker.QueryResponse submit(Worker.QueryRequest request, long
timeoutMs) {
+ return _blockingStub.withDeadlineAfter(timeoutMs,
TimeUnit.MILLISECONDS).submit(request);
Review Comment:
Can we pass in withDeadline instead so they have the same deadline?
Let's work on rpc deadline first and do async RPC in a separate PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
