jackjlli commented on code in PR #10247:
URL: https://github.com/apache/pinot/pull/10247#discussion_r1100828422
##########
pinot-controller/src/main/java/org/apache/pinot/controller/api/events/MetadataEventNotifierFactory.java:
##########
@@ -26,22 +27,21 @@
public abstract class MetadataEventNotifierFactory {
public static final Logger LOGGER =
LoggerFactory.getLogger(MetadataEventNotifierFactory.class);
public static final String METADATA_EVENT_CLASS_CONFIG = "factory.class";
-
- public abstract void init(PinotConfiguration configuration);
+ public abstract void init(PinotConfiguration configuration,
PinotHelixResourceManager pinotHelixResourceManager);
Review Comment:
nit: add one empty line before this statement.
##########
pinot-controller/src/main/java/org/apache/pinot/controller/api/events/DefaultMetadataEventNotifierFactory.java:
##########
@@ -18,15 +18,17 @@
*/
package org.apache.pinot.controller.api.events;
+import org.apache.pinot.controller.helix.core.PinotHelixResourceManager;
import org.apache.pinot.spi.env.PinotConfiguration;
public class DefaultMetadataEventNotifierFactory extends
MetadataEventNotifierFactory {
- public MetadataEventNotifier create() {
- return new DefaultMetadataEventNotifier();
+ @Override
+ public void init(PinotConfiguration configuration, PinotHelixResourceManager
pinotHelixResourceManager) {
}
- public void init(PinotConfiguration configuration) {
+ public MetadataEventNotifier create() {
Review Comment:
Add `@Override` annotation here as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
