walterddr commented on code in PR #10285:
URL: https://github.com/apache/pinot/pull/10285#discussion_r1107375094
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/MailboxReceiveOperator.java:
##########
@@ -67,19 +67,21 @@ public class MailboxReceiveOperator extends
MultiStageOperator {
private int _serverIdx;
private TransferableBlock _upstreamErrorBlock;
- private static MailboxIdentifier toMailboxId(VirtualServer sender, long
jobId, long stageId,
- VirtualServerAddress receiver) {
+ private static MailboxIdentifier toMailboxId(VirtualServer sender, long
jobId, int senderStageId,
+ int receiverStageId, VirtualServerAddress receiver) {
return new JsonMailboxIdentifier(
- String.format("%s_%s", jobId, stageId),
+ String.format("%s_%s", jobId, senderStageId),
Review Comment:
i dont know if we still want to keep the senderStage in the jobId format.
since now you have the sender/receiver id already in the mailboxIdentifier impl
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/MailboxSendOperator.java:
##########
@@ -153,10 +155,10 @@ protected TransferableBlock getNextBlock() {
}
private static JsonMailboxIdentifier toMailboxId(
- VirtualServer destination, long jobId, int stageId, VirtualServerAddress
sender) {
+ VirtualServer destination, long jobId, int stageId, int receiverStageId,
VirtualServerAddress sender) {
Review Comment:
nit: make it consistent, plz change it to senderStageId/receiverStageId
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/mailbox/MailboxIdentifier.java:
##########
@@ -50,4 +50,8 @@ public interface MailboxIdentifier {
* @return true if sender and receiver are in the same JVM.
*/
boolean isLocal();
+
+ int getSenderStageId();
+
+ int getReceiverStageId();
Review Comment:
neither API is used please at least add test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
