xiangfu0 commented on code in PR #10294:
URL: https://github.com/apache/pinot/pull/10294#discussion_r1110415393
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/HashJoinOperator.java:
##########
@@ -215,32 +215,44 @@ private TransferableBlock
buildJoinedDataBlock(TransferableBlock leftBlock)
List<Object[]> container = leftBlock.isEndOfStreamBlock() ? new
ArrayList<>() : leftBlock.getContainer();
for (Object[] leftRow : container) {
Key key = new Key(_leftKeySelector.getKey(leftRow));
- // NOTE: Empty key selector will always give same hash code.
- List<Object[]> matchedRightRows = _broadcastRightTable.getOrDefault(key,
null);
- if (matchedRightRows == null) {
- if (needUnmatchedLeftRows()) {
- rows.add(joinRow(leftRow, null));
+ if (_joinType != JoinRelType.SEMI && _joinType != JoinRelType.ANTI) {
Review Comment:
using switch-case?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
