snleee commented on code in PR #10302:
URL: https://github.com/apache/pinot/pull/10302#discussion_r1110420914
##########
pinot-broker/src/main/java/org/apache/pinot/broker/routing/instanceselector/BaseInstanceSelector.java:
##########
@@ -231,7 +231,7 @@ void updateSegmentMaps(IdealState idealState, ExternalView
externalView, Set<Str
*/
@Nullable
private List<String> calculateEnabledInstancesForSegment(String segment,
List<String> onlineInstancesForSegment,
- Set<String> unavailableSegments) {
+ Set<String> unavailableSegments, String debugString) {
Review Comment:
Can we avoid adding`debugString`? Instead, we can log whether it's from
assignment/instance change from the caller. Then, we should be able to check
the logs to find the same information.
```
LOGGER.info("Calculating enabled instances on assignment(or instance in
another block) change");
List<String> enabledInstancesForSegment =
calculateEnabledInstancesForSegment(segment, entry.getValue(),
unavailableSegments);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
