yuanbenson commented on code in PR #10303:
URL: https://github.com/apache/pinot/pull/10303#discussion_r1113518075
##########
pinot-common/src/main/java/org/apache/pinot/common/lineage/SegmentLineageUtils.java:
##########
@@ -53,4 +54,19 @@ public static void
filterSegmentsBasedOnLineageInPlace(Set<String> segments, Seg
}
}
}
+
+ public static Set<String> getDuplicateSegmentsToFilterOut(SegmentLineage
segmentLineage) {
Review Comment:
Yes, good point. Replaced segments don't necessarily mean duplicates, made
this over-simplification while implementing by mistake :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
