somandal commented on code in PR #10286:
URL: https://github.com/apache/pinot/pull/10286#discussion_r1117708927
##########
pinot-query-runtime/src/test/java/org/apache/pinot/query/runtime/QueryRunnerTestBase.java:
##########
@@ -364,6 +371,8 @@ public static class Query {
public List<List<Object>> _outputs = null;
@JsonProperty("expectedException")
public String _expectedException;
+ @JsonProperty("keepOutputRowOrder")
+ public boolean _keepOutputRowOrder;
Review Comment:
done, ran into an issue with a few tests and left TODOs to look into them
later along with comments explaining what I think is going on. As a follow up
perhaps I can revisit making this 'keepOutputRowOrder' less flaky in terms of
ordering (i.e. handle scenarios where the order by key is correctly ordered but
there are ties)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
