somandal commented on code in PR #10286:
URL: https://github.com/apache/pinot/pull/10286#discussion_r1124017823
##########
pinot-query-planner/src/main/java/org/apache/calcite/rel/rules/PinotWindowExchangeNodeInsertRule.java:
##########
@@ -48,7 +48,7 @@ public class PinotWindowExchangeNodeInsertRule extends
RelOptRule {
// Supported window functions
private static final Set<SqlKind> SUPPORTED_WINDOW_FUNCTION_KIND =
ImmutableSet.of(SqlKind.SUM, SqlKind.SUM0,
- SqlKind.MIN, SqlKind.MAX, SqlKind.COUNT);
+ SqlKind.MIN, SqlKind.MAX, SqlKind.COUNT, SqlKind.OTHER_FUNCTION);
Review Comment:
Ah good point, I think we just saw that PostgreSQL has support for all
aggregation functions and thought why not add what we have (at least the basic
ones). Hope it's alright to leave this here. I've updated to add a comment here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
