[GitHub] [pinot] sahoss commented on issue #10316: Add JSON integration tests to LLCRealtimeClusterIntegrationTest

Fri, 03 Mar 2023 06:07:25 -0800 


sahoss commented on issue #10316:
URL: https://github.com/apache/pinot/issues/10316#issuecomment-1453583245

   **Potential source of bug**
   It seems error is in BaseRecordExtractor. When processing the json node:  
`{"key1": [], "key2": [1, 2], "key3": "value"`, the empty key is present.
   
![image](https://user-images.githubusercontent.com/126167264/222739777-df4f032a-06a3-4de2-82ca-5469ed6a251e.png)
   
   It recurses to process node `"key1": []`  and returns null from convert() 
method. This is because convertMultiValue() checks for empty collection and 
returns null.
   
![image](https://user-images.githubusercontent.com/126167264/222739924-20df8556-70d6-4adf-81a4-df554ddefbf2.png)
   
   
![image](https://user-images.githubusercontent.com/126167264/222740171-56223b23-66dd-44d0-8e54-26d30f2e5930.png)
   
   Code pointers:
   
   
https://github.com/apache/pinot/blob/master/pinot-spi/src/main/java/org/apache/pinot/spi/data/readers/BaseRecordExtractor.java#L109
 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to