ankitsultana commented on code in PR #10322:
URL: https://github.com/apache/pinot/pull/10322#discussion_r1128209233
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/executor/OpChainSchedulerService.java:
##########
@@ -68,6 +68,7 @@ protected void run()
@Override
public void runJob() {
boolean isFinished = false;
+ boolean returnedErrorBlock = false;
Review Comment:
Let's keep them in the same PR since this enforces the behavior that we
should call Operator#cancel when there's an error-block returned.
A MailboxReceiveOperator may receive data from multiple mailbox (say 10 of
them).
If one of them returns an error-block we bubble up the error-block
immediately, so the other mailbox may still be active. So we shouldn't simply
close the Operator but rather cancel to signal an early-termination.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
