ankitsultana commented on code in PR #10401:
URL: https://github.com/apache/pinot/pull/10401#discussion_r1131779563
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/executor/OpChainSchedulerService.java:
##########
@@ -43,10 +46,16 @@ public class OpChainSchedulerService extends
AbstractExecutionThreadService {
private final OpChainScheduler _scheduler;
private final ExecutorService _workerPool;
+ private final Cache<Long, Long> _cancelledRequests;
public OpChainSchedulerService(OpChainScheduler scheduler, ExecutorService
workerPool) {
+ this(scheduler, workerPool,
QueryConfig.DEFAULT_SCHEDULER_RELEASE_TIMEOUT_MS);
Review Comment:
The scheduler release timeout is used for promoting queries from available
state to running state. Can we use a different value here? Ideally that value
should be a bit higher than the release timeout.
Also, you can use `expireAfterWrite` instead since that seems more intuitive
in this case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
