gortiz commented on code in PR #10191: URL: https://github.com/apache/pinot/pull/10191#discussion_r1132203851
########## pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/index/IndexReaderConstraintException.java: ########## @@ -0,0 +1,47 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.pinot.segment.spi.index; + +public class IndexReaderConstraintException extends Exception { + public IndexReaderConstraintException() { + } + + public IndexReaderConstraintException(String message) { + super(message); + } + + public IndexReaderConstraintException(String columnName, IndexType<?, ?, ?> type, String constraintDesc, + Throwable cause) { + this("Cannot read an index of type " + type + " on column " + columnName + ". Reason: " + constraintDesc, Review Comment: I think that is a personal taste. I find String.format quite more difficult to read given that I have to move my _reading cursor_ to the end of the sentence in order to know what is going to feel the format variable. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
