walterddr commented on code in PR #10401:
URL: https://github.com/apache/pinot/pull/10401#discussion_r1132827334
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/executor/OpChainSchedulerService.java:
##########
@@ -38,15 +40,28 @@
@SuppressWarnings("UnstableApiUsage")
public class OpChainSchedulerService extends AbstractExecutionThreadService {
private static final Logger LOGGER =
LoggerFactory.getLogger(OpChainSchedulerService.class);
- // Default time scheduler is allowed to wait for a runnable OpChain to be
available
+ /**
+ * Default time scheduler is allowed to wait for a runnable OpChain to be
available.
+ */
private static final long DEFAULT_SCHEDULER_NEXT_WAIT_MS = 100;
+ /**
+ * Default cancel signal retention, this should be set to several times
larger than
+ * {@link
org.apache.pinot.query.service.QueryConfig#DEFAULT_SCHEDULER_RELEASE_TIMEOUT_MS}.
+ */
+ private static final long DEFAULT_SCHEDULER_CANCELLATION_SIGNAL_RETENTION_MS
= 60_000L;
private final OpChainScheduler _scheduler;
private final ExecutorService _workerPool;
+ private final Cache<Long, Long> _cancelledRequests;
public OpChainSchedulerService(OpChainScheduler scheduler, ExecutorService
workerPool) {
+ this(scheduler, workerPool,
DEFAULT_SCHEDULER_CANCELLATION_SIGNAL_RETENTION_MS);
+ }
+
+ public OpChainSchedulerService(OpChainScheduler scheduler, ExecutorService
workerPool, long cancelRetentionMs) {
_scheduler = scheduler;
_workerPool = workerPool;
+ _cancelledRequests =
CacheBuilder.newBuilder().expireAfterWrite(cancelRetentionMs,
TimeUnit.MILLISECONDS).build();
Review Comment:
TL;DR this time is not associated with query timeout user set.
long answer:
this is the cancel signal retention in the scheduler. ideally the query
opChain will be waken up in milliseconds. in case of failure/error state it
will be waken up at least once per DEFAULT_SCHEDULER_RELEASE_TIMEOUT_MS (which
is 10second).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
