chenboat commented on code in PR #10400:
URL: https://github.com/apache/pinot/pull/10400#discussion_r1132987155
##########
pinot-spi/src/main/java/org/apache/pinot/spi/config/table/SegmentsValidationAndRetentionConfig.java:
##########
@@ -52,6 +52,10 @@ public class SegmentsValidationAndRetentionConfig extends
BaseJsonConfig {
// Number of replicas per partition of low-level consumers. This config is
used for realtime tables only.
private String _replicasPerPartition;
+ // True if and only if the segment upload to deep store is disabled. This is
usefully for Pinot cluster which does not
+ // have any deep store.
+ private boolean _segmentUploadToDeepStoreDisabled;
Review Comment:
Yes. If there is no deep store copy, the rebalance with downtime will result
in segment data loss. I will add a note about this mode of ingestion with its
limitation. We can also file a PR to detect the missing segments during
rebalance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
