Jackie-Jiang commented on code in PR #10405:
URL: https://github.com/apache/pinot/pull/10405#discussion_r1134726150
##########
pinot-core/src/main/java/org/apache/pinot/core/operator/query/AggregationOperator.java:
##########
@@ -63,25 +62,25 @@ protected AggregationResultsBlock getNextBlock() {
} else {
aggregationExecutor = new
DefaultAggregationExecutor(_aggregationFunctions);
}
- TransformBlock transformBlock;
- while ((transformBlock = _transformOperator.nextBlock()) != null) {
- _numDocsScanned += transformBlock.getNumDocs();
- aggregationExecutor.aggregate(transformBlock);
+ ValueBlock valueBlock;
+ while ((valueBlock = _projectOperator.nextBlock()) != null) {
+ _numDocsScanned += valueBlock.getNumDocs();
+ aggregationExecutor.aggregate(valueBlock);
}
// Build intermediate result block based on aggregation result from the
executor
return new AggregationResultsBlock(_aggregationFunctions,
aggregationExecutor.getResult());
}
@Override
- public List<Operator> getChildOperators() {
- return Collections.singletonList(_transformOperator);
+ public List<BaseProjectOperator<?>> getChildOperators() {
Review Comment:
IDE is showing warning because the generic type is not included
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
