Jackie-Jiang commented on code in PR #10359:
URL: https://github.com/apache/pinot/pull/10359#discussion_r1136286239
##########
pinot-common/src/main/java/org/apache/pinot/common/metadata/controllerjob/ControllerJobType.java:
##########
@@ -20,6 +20,6 @@
public enum ControllerJobType {
RELOAD_SEGMENT,
- RELOAD_ALL_SEGMENTS,
Review Comment:
Do we merge `RELOAD_ALL_SEGMENTS` into `RELOAD_SEGMENT`? Some changes seems
unrelated to the current PR topic
##########
pinot-common/src/main/java/org/apache/pinot/common/metadata/ZKMetadataProvider.java:
##########
@@ -112,14 +112,14 @@ public static String
constructPropertyStorePathForInstancePartitions(String inst
return StringUtil.join("/", PROPERTYSTORE_INSTANCE_PARTITIONS_PREFIX,
instancePartitionsName);
}
- public static String constructPropertyStorePathForControllerJob() {
- return StringUtil.join("/", PROPERTYSTORE_CONTROLLER_JOBS_PREFIX);
- }
-
public static String constructPropertyStorePathForResource(String
resourceName) {
return StringUtil.join("/", PROPERTYSTORE_SEGMENTS_PREFIX, resourceName);
}
+ public static String
constructPropertyStorePathForControllerJobResource(String resourceName) {
Review Comment:
Reading the following code, we are actually passing the job type instead of
the resource name (resource name is the table name with type, e.g.
`myTable_OFFLINE`)
##########
pinot-common/src/main/java/org/apache/pinot/common/metadata/ZKMetadataProvider.java:
##########
@@ -112,14 +112,14 @@ public static String
constructPropertyStorePathForInstancePartitions(String inst
return StringUtil.join("/", PROPERTYSTORE_INSTANCE_PARTITIONS_PREFIX,
instancePartitionsName);
}
- public static String constructPropertyStorePathForControllerJob() {
Review Comment:
Do we also change the ZK location for existing controller jobs? I'd suggest
making it a separate PR because that is not in the scope of this PR
##########
pinot-common/src/main/java/org/apache/pinot/common/metadata/ZKMetadataProvider.java:
##########
@@ -112,14 +112,14 @@ public static String
constructPropertyStorePathForInstancePartitions(String inst
return StringUtil.join("/", PROPERTYSTORE_INSTANCE_PARTITIONS_PREFIX,
instancePartitionsName);
}
- public static String constructPropertyStorePathForControllerJob() {
- return StringUtil.join("/", PROPERTYSTORE_CONTROLLER_JOBS_PREFIX);
- }
-
public static String constructPropertyStorePathForResource(String
resourceName) {
return StringUtil.join("/", PROPERTYSTORE_SEGMENTS_PREFIX, resourceName);
}
+ public static String
constructPropertyStorePathForControllerJobResource(String resourceName) {
Review Comment:
Are we going to create one ZNode per table?
##########
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotTableRestletResource.java:
##########
@@ -712,6 +720,36 @@ public String getTableState(
}
}
+ @GET
+ @Produces(MediaType.APPLICATION_JSON)
+ @Authenticate(AccessType.UPDATE)
+ @Path("/rebalanceStatus/{jobId}")
+ @ApiOperation(value = "Gets detailed stats of a rebalance operation",
+ notes = "Gets detailed stats of a rebalance operation")
+ public ServerRebalanceJobStatusResponse rebalanceStatus(@ApiParam(value =
"Rebalance Job Id", required = true)
Review Comment:
Please reformat all the changes with [Pinot
Style](https://docs.pinot.apache.org/developers/developers-and-contributors/code-setup#setup-ide)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
