gortiz commented on code in PR #10192:
URL: https://github.com/apache/pinot/pull/10192#discussion_r1138354380
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/creator/impl/bloom/OnHeapGuavaBloomFilterCreator.java:
##########
@@ -47,9 +48,18 @@ public class OnHeapGuavaBloomFilterCreator implements
BloomFilterCreator {
private final File _bloomFilterFile;
private final BloomFilter<String> _bloomFilter;
+ private final FieldSpec.DataType _dataType;
+ // TODO: This method is here for compatibility reasons, should be removed in
future PRs
Review Comment:
I see your point, but I don't actually know when it could be removed. There
should be no usages of this method once the complete PR is merged, but I kept
it there just in case some people out there is using that constructor. We can
simply remove it if you prefer.
What I'm going to do is to change the comment into something like:
`exit_criteria: remove once #10184 is merged`
(https://github.com/apache/pinot/pull/10184 is the complete PR)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
